Hey Stefan, > I managed to track down the ref-counting bug in the cython-closures branch. > Function arguments that participated in the closure were not always > INCREFed, which induced several problems with the cleanup of the closure > class instance as it expected that any non-NULL field could safely be > DECREF-ed. Especially errors during argument conversion were pretty deadly. >
Sweet! That's interesting ... I won't get time to sit down and look at the patch until tonight at the earliest, but I'm looking forward to seeing what the issue was. > After this fix, all tests in the cython-closures pass, and even the > failures in the Python regression suite start to get interesting. > > So, unless there are still objections from others, my vote is for getting > it merged back into mainline (it's already up-to-date with cython-devel) > and pushing out a 0.13 alpha. (Last I heard, Sage was still failing to > build, but that doesn't have to keep us from getting an alpha version out, > does it?) > This sounds reasonable enough, with one caveat: if something in the closures branch causes huge issues with Sage, we'll either need to keep delaying 0.13 or revert. I can't imagine why it would, but those are famous last words. :) -cc _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
