On 9 June 2010 13:37, Chuck Blake <[email protected]> wrote: > Lisandro Dalcin wrote: >>Looks fine, but I think you should follow the i/I rules. Any other opinion? > > I hesitated to speculate why it might have been capital Z in the first > place. Someone might have been thinking of using lowercase z for the > unsigned version Py_size_t, but that isn't in use anywhere [ or else the > letter slot would be used :) ]. Given that there is more of an existing > indirection case convention, I agree that seems clearer. > > There are also a couple (more implicit) Signature uses in Builtin.py > as well as TypeSlots.py. > > So, if you prefer (as I and Lisandro do) the z/Z scalar/pointer version > of all this, I've gone ahead and attached that version of this fix as > well, in hg export format this time. This is more invasive and harder > to guarantee to be non-impacting of other code. There are no other uses > of Signature() objects that I can find besides Bultin and Typeslots, > though, at least by searching for '\<Signature\>('. > > This one also deletes getreadbufferproc and the other get*buffer* > Signature variables as they are no longer relevant. (The C signatures > are all the same with the Cython compatibility typedef making them > actually different. So, the upstream Python typename shufflng around > with gets coming and going no longer matters). > > I also tested this version against 2.4, 2.5, 2.6, and 3.1. >
The patch looks good. I'll give it a more closer look very soon. If no one objects, I'll push it by tomorrow. Chuck, could I use "Chuck Blake <[email protected]>" as the author commit? A "cb" author name is not descriptive enough we want to give proper credits to all contributions. -- Lisandro Dalcin --------------- CIMEC (INTEC/CONICET-UNL) Predio CONICET-Santa Fe Colectora RN 168 Km 472, Paraje El Pozo Tel: +54-342-4511594 (ext 1011) Tel/Fax: +54-342-4511169 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
