On Sat, Jul 17, 2010 at 3:46 AM, Stefan Behnel <[email protected]> wrote: > Craig Citro, 17.07.2010 09:49: >> I think the subject line pretty much says it all -- I just >> successfully built sage-4.4.4 against the tip of cython-closures, and >> it builds, runs, and passes all doctests(*).
Excellent news! >> As far as I'm concerned, >> that means it's time to roll ourselves an alpha. (Robert, do you want >> to tell me what steps are involved in that? Is there a list >> somewhere?) Also, what's the general rule for avoiding someone >> clobbering the "working" state with a push? Should I just add a tag >> for "0.13-alpha0" and we could always recover from there? I think it's worth rolling an alpha, noting that there are still some failures, and get it out there. When we get everything actually passing, we're at beta stage. I don't feel too strongly about this. > I only fixed a couple of things in the genexpr inlining code which > shouldn't have any impact on existing Cython code bases, so the latest tip > will work just as well. However, we're not there yet. I would like to have > Cython's own test suite green on all Python versions even before the alpha. > > >> I just ran the Cython tests in the closures branch itself -- it looks >> like there are a few doctest failures with the recent code there. > > Yes, a handful of tests still fail in Py3. > > http://trac.cython.org/cython_trac/ticket/543 > > Looks like Haoyu has a fix for at least one of them. > > >> I'm happy to start helping with these tomorrow, but can we designate >> cython-closures as "bugfix only" until the actual release? For that >> matter, with closures becoming devel, soon we won't need a closures >> branch anymore ... finally. ;) > > Note that we don't currently run the Hudson tests on all Python platforms > for cython-closures but only for cython-devel. I'd suggest merging > cython-closures into cython-devel before releasing the alpha, and giving > Hudson a couple of minutes to run all tests to see if we missed anything > there (which we likely did). Good idea. > I'll take a look at the current cython-devel failures in Py<=2.5 as I broke > at least one of them while fixing Unicode problems on narrow platforms, but > I'd be happy to get some help in fixing the others. Some tests have been > broken for ages. See e.g. the end of > > https://sage.math.washington.edu:8091/hudson/view/cython-devel/job/cython-devel-tests-py24-c/138/console What's the ETA for this? I thought that once Sage built, that was the last major problem. In any case, +1 to merging into -devel and making that bugfix-only so we can actually release. Does anyone want to go to http://trac.cython.org/cython_trac/milestone/0.13 and bump stuff to 0.13.1 (or later) if it's not trivial or a blocker? (I'll do this if no one beats me too it, but I've got to run now.) - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
