>Looks good to me, thanks! I'm not sure pyrex_directive is the right >attribute to use here, as pyrex itself doesn't have (as far as I know) >the notion of directives, but that's not a big deal and I'm sure it'll >be very useful. I've pushed it.
Everything else is the distutils stuff is prefixed with pyrex_, and I believe some of those are cython-only as well. I'm already loving infertypes.verbose enabled on all my packages. There was a problem with the Hudson autobuild. I probably too closely imitated the logic for pyrex_include_dirs...The attached fixes it and I don't think will ever be wrong but someone might want to look at this more carefully. (Also, sorry about the original subject line.).
# HG changeset patch # User Chuck Blake <[email protected]> # Date 1279851105 14400 # Node ID 30e0e8a9169ea14821336257fe71733cd58f582e # Parent f3ce2586682a874544a1ceb2318ab388fbc81f3e Easy enough to wrap in a hasattr. On my system only py31 complains, but on the Hudson autobuild, most versions complain about a missing attribute. diff -r f3ce2586682a -r 30e0e8a9169e Cython/Distutils/build_ext.py --- a/Cython/Distutils/build_ext.py Thu Jul 22 18:17:46 2010 -0400 +++ b/Cython/Distutils/build_ext.py Thu Jul 22 22:11:45 2010 -0400 @@ -149,7 +149,8 @@ # 2. Add in any (unique) entries from the extension # pyrex_directives (if Cython.Distutils.extension is used). directives = self.pyrex_directives - directives.update(extension.pyrex_directives) + if hasattr(extension, "pyrex_directives"): + directives.update(extension.pyrex_directives) # Set the target_ext to '.c'. Cython will change this to '.cpp' if # needed.
_______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
