Vitja Makarov, 27.11.2010 17:11: > 2010/11/27 Stefan Behnel: >> Vitja Makarov, 27.11.2010 09:28: >>> I've attached patch to ticket #308, not sure right place for it. >> >> Not quite the right place. That ticket is about keeping module level C >> names local to the module *instance* instead of the module's C code. Looks >> like the lambda reference is actually unrelated after all. >> >> Could you create a new ticket for this? It's better to have a ticket for a >> single feature that we can close (with a name on it) when it's done. >> >> Then, please add a test that involves typed cdef names at the module level >> and also a case where Cython can infer expression types (unicode indexing >> maybe?). Having these things work at the Python level is great, but for the >> Cython language, we always need to make sure that name lookups, type >> inference etc. work as expected, and these are scope dependent. Those are >> things that CPython's regression tests cannot cover. >> >> You can also type parameters in lambda expressions, see the tests in >> run/lambda_T195.pyx. That's not related to this patch, but you can use it >> in your tests to check that type inference/analysis works correctly here. > > I've created ticket http://trac.cython.org/cython_trac/ticket/603 > > And added some more tests but I'm not sure that they cover all the cases. > Can you please add some?
I think what you have there is just fine and passes nicely. Thanks! Stefan _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
