On Fri, Jan 28, 2011 at 3:59 AM, mark florisson <markflorisso...@gmail.com> wrote: > On 28 January 2011 08:40, Robert Bradshaw <rober...@math.washington.edu> > wrote: >> On Tue, Jan 25, 2011 at 1:46 PM, Vitja Makarov <vitja.maka...@gmail.com> >> wrote: >>> It's okay now. But with few warnings. >>> >>> vitja@vitja-laptop:~/work/cython.git$ python runtests.py -vv --no-cpp >>> --no-annotate libc >>> Python 2.6.6 (r266:84292, Sep 15 2010, 16:22:56) >>> [GCC 4.4.5] >>> >>> Running tests against Cython 0.14.1rc2 >>> >>> test_all (Cython.Debugger.Tests.TestLibCython.TestAll) ... warning: >>> codefile.pyx:25:6: 'eggs' redeclared >>> ....Function "__pyx_pf_8codefile_5outer_inner" not defined. >>> .................. >>> ---------------------------------------------------------------------- >>> Ran 22 tests in 8.263s >> >> I would like to get rid of these warnings if possible... >> >> - Robert >> _______________________________________________ >> Cython-dev mailing list >> Cython-dev@codespeak.net >> http://codespeak.net/mailman/listinfo/cython-dev >> > > I see you duplicated the checks for the gdb and python versions in a > global function. Are you still working on removing the duplication? > (I'm talking about the code in > Cython/Debugger/Tests/TestLibCython:GdbDebuggerTestCase.setUp).
The global function caches its value, so it's only doing the actual check once, but we do want to guard both bodies (on the assumption that later tests could be written). BTW, thanks for writing these tests for the debugger. It's unfortunate that 7.2 is still so new (or maybe, that so many systems are so behind) but I know what a pain it is to write tests for something interactive like this, so kudos to you. - Robert _______________________________________________ Cython-dev mailing list Cython-dev@codespeak.net http://codespeak.net/mailman/listinfo/cython-dev
