Vitja Makarov, 23.08.2011 07:29:
2011/8/23 Vitja Makarov:
2011/8/23 Robert Bradshaw:
On Mon, Aug 22, 2011 at 9:41 PM, Stefan Behnel wrote:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python
compatibility, which disables the signature optimisation into METH_O&
friends for def functions. That helped in a couple of cases but broke
others. The regression appears to be mostly because generator expressions do
not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for
now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy
fix (I tried but didn't find the right place to fix it).
IIRC, it is a significant performance penalty to turn that off (which
is why it's disabled by default). We should at least allow one to
disable it.
That's switched on only for pyregr tests
Right, but it's still a useful option for Python compatibility in general.
I've fixed it here
https://github.com/cython/cython/commit/7c01e8488e12f5e7581a356df5882d5329457369
Ah, given the right pair of eyeballs ...
Thanks!
Stefan
_______________________________________________
cython-devel mailing list
cython-devel@python.org
http://mail.python.org/mailman/listinfo/cython-devel
