On 6 May 2012 09:56, mark florisson <[email protected]> wrote: > On 5 May 2012 20:50, Stefan Behnel <[email protected]> wrote: >>> https://github.com/cython/cython/pull/113 >> >> This looks ok to me now. There have been objections back when we discussed >> the initial patch for array.array support, so what do you think about >> merging this in? >> >> Stefan >> _______________________________________________ >> cython-devel mailing list >> [email protected] >> http://mail.python.org/mailman/listinfo/cython-devel > > Great, I think it can be quite useful for some people. I think only > some documentation is missing. > > Also, very minor complaint, the way it allocates shape, strides and > the format string in __getbuffer__ is weird and complicated for no > good reason. I think it's better to declare two Py_ssize_t scalars or > one-sized arrays as class attributes and one char[2] array, and use > those (then you can also get rid of __releasebuffer__).
Or hm, that might be a problem with their variable nature? Then the shape of the buffer would suddenly change... Maybe malloc is better in __getbuffer__ then. _______________________________________________ cython-devel mailing list [email protected] http://mail.python.org/mailman/listinfo/cython-devel
