On 23 July 2012 19:55, Stefan Behnel <stefan...@behnel.de> wrote: > mark florisson, 23.07.2012 20:07: >> On 23 July 2012 18:54, Stefan Behnel wrote: >>> mark florisson, 17.07.2012 12:20: >>>> On 17 July 2012 10:02, Stefan Behnel wrote: >>>>> mark florisson, 10.07.2012 11:20: >>>>>> Do you want _refactor_indexnode merged for this release? >>>>> >>>>> I was ok with it when I first skipped over it. It would be good to give it >>>>> another pair of eyeballs, but apart from that, yes, I think it should go >>>>> in. I'll merge it as soon as Jenkins is happy with the test suite again >>>>> (and after re-enabling the broken tests, which are related after all), so >>>>> that we can see if everything is ok after the merge. >>>> >>>> Hm, some things changed here. I rebased my current working branch >>>> (_array_expressions) on that branch, and then I moved the buffer and >>>> memoryview tests into their own directories in master, and I think I >>>> rebased my devel branch along with _refactor_indexnode on master. So >>>> I'll have to renew that pull request using the final rebase. I'll then >>>> rebase the rest of my working branch on master. >>> >>> Would you have an estimate when this will be done? It would be good if this >>> could be merged for the alpha, to avoid too much code churn after the first >>> user tests. >> >> Sorry, I forgot to do this. Actually if you want I can do it now, but >> since it doesn't really bring any features it might be better to have >> it wait until next release if it happens to break things. Your call, >> I'll make a new PR. > > Hmm, revisiting the amount of code that this changes now, I would prefer > taking a step back, playing safe and leaving this for the next release. > Sorry to have rushed you here, but it carries a considerable risk for the > release. We can merge it right when 0.17 is out, I don't expect any major > changes till then that would require yet another rebase of your pull request. > > Stefan > > _______________________________________________ > cython-devel mailing list > cython-devel@python.org > http://mail.python.org/mailman/listinfo/cython-devel
Great, totally understandable. Was this comment "Note that some aspects of the memory views feature may not currently work in Python 2.4.x. This is a known bug." in the release notes about the copying of Python slice objects? _______________________________________________ cython-devel mailing list cython-devel@python.org http://mail.python.org/mailman/listinfo/cython-devel