On Wed, May 18, 2016 at 12:22 AM, Robert Bradshaw <rober...@gmail.com> wrote:
> On Fri, May 13, 2016 at 4:26 AM, Erik Bray <erik.m.b...@gmail.com> wrote:
>> On Thu, May 12, 2016 at 12:55 AM, Greg Ewing
>> <greg.ew...@canterbury.ac.nz> wrote:
>>> Erik Bray wrote:
>>>>
>>>> A developer who writes some code that
>>>> happens to use long double isn't going to think themselves "Gosh, I
>>>> guess I can't accept `long double` here because it may cause Cython to
>>>> generate code that contains "truncl"
>>>
>>>
>>> Sounds to me like Cython shouldn't be taking it upon
>>> itself to generate calls to truncl just because long
>>> double is being used. The programmer should have to
>>> call it explicitly if that's what they want.
>>
>> Since it's just a small optimization it could be disabled without
>> trouble too.  Preferably with a #define that can be set or unset at
>> compile time.
>
> https://github.com/cython/cython/commit/46d3efc4ff9123c73889bcb54b2b200d6be39ff4

The commit looks good to me.  Sorry I somehow missed this earlier.

The other cases are a bit hairier, but this is the one I was most
concerned about since it doesn't explicitly involve any operations
with long doubles.

Thanks,
Erik
_______________________________________________
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel

Reply via email to