> On 31 Jan 2020, at 16:51, Greg Ewing <greg.ew...@canterbury.ac.nz> wrote:
> 
> On 31/01/20 9:47 am, John Skaller2 wrote:
> 
>>>> 2. pyport is plain wrong. It contains conflicting C typedefs.
>>> 
>>> PRs welcome.
>> Is this your prefered method (pull request)?
> 
> I'm sure PRs are very welcome, but at the least you could
> give us some idea of what these conflicting typedefs are!


The file is small:

cdef extern from "Python.h":
    ctypedef int int32_t
    ctypedef int int64_t
    ctypedef unsigned int uint32_t
    ctypedef unsigned int uint64_t

Obviously this is an incorrect translation of the original source.
One of each pair may well be correct. But its impossible both are.
Defining a symbol defined in the C99 standard seems like a bad idea.

Python’s pyport.h actually says:

#include <inttypes.h>
..
#define PY_UINT32_T uint32_t
#define PY_UINT64_T uint64_t

/* Signed variants of the above */
#define PY_INT32_T int32_t
#define PY_INT64_T int64_t

…


—
John Skaller
skal...@internode.on.net





_______________________________________________
cython-devel mailing list
cython-devel@python.org
https://mail.python.org/mailman/listinfo/cython-devel

Reply via email to