> I don't think 3 is worthwhile. I tend to agree.
> I weakly prefer 1 to 2 on the basis that we were trying to get away from Options where possible. I think I have the same opinion. `Option` variant is much simpler and I cannot see any benefit using a shared module with only a subset of .pyx files. Matus On Mon, 3 Mar 2025 at 21:07, da-woods <dw-...@d-woods.co.uk> wrote: > Personally: > > I don't think 3 is worthwhile. > > I weakly prefer 1 to 2 on the basis that we were trying to get away from > Options where possible. However, this is probably a case where Options > will usually be right (it forces a setting on every module that you're > processing in a batch, which is what most people will want here. But maybe > not everyone). > > David > > > On 03/03/2025 19:47, matus valo wrote: > > Hi All, > > Based on the comment > https://github.com/cython/cython/pull/6531#discussion_r1975502026 I would > like to start a discussion about using Option vs Compilation Directive. > Basically, we have 3 options: > > 1. Use PR https://github.com/cython/cython/pull/6531 as is. I will > proceed with the rest of the comments. > 2. Use `Option` directly with no further changes in the Cython codebase. > This is the initial implementation. I created a branch with a version of > the PR with rollback of all changes related to the Compilation Directive > adjustments: > https://github.com/cython/cython/compare/master...matusvalo:shared_library_option?expand=1 > 3. Use code changes/cleanup in https://github.com/cython/cython/pull/6646 > but Shared Utility will be configured using `Option` instead of Compilation > directive (Option 2.). I am not sure it this point makes sense, only in > case that we want to keep changes by @da-woods <dw-...@d-woods.co.uk> improves > the code internals. > > I would like to have an agreement on this topic before moving forward with > other comments in the PR. > > > Thanks, > > Matus > >
_______________________________________________ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel
