Author: jm
Date: 2012-06-27 09:23:44 -0700 (Wed, 27 Jun 2012)
New Revision: 29704
Modified:
core3/impl/trunk/core-task-impl/src/main/java/org/cytoscape/task/internal/creation/NewEmptyNetworkTaskFactoryImpl.java
Log:
Fixes #1175: Fixed leak of CyNetworkView
Modified:
core3/impl/trunk/core-task-impl/src/main/java/org/cytoscape/task/internal/creation/NewEmptyNetworkTaskFactoryImpl.java
===================================================================
---
core3/impl/trunk/core-task-impl/src/main/java/org/cytoscape/task/internal/creation/NewEmptyNetworkTaskFactoryImpl.java
2012-06-27 13:45:02 UTC (rev 29703)
+++
core3/impl/trunk/core-task-impl/src/main/java/org/cytoscape/task/internal/creation/NewEmptyNetworkTaskFactoryImpl.java
2012-06-27 16:23:44 UTC (rev 29704)
@@ -50,8 +50,6 @@
private final SynchronousTaskManager<?> syncTaskMgr;
private final VisualMappingManager vmm;
- private NewEmptyNetworkTask task;
-
public NewEmptyNetworkTaskFactoryImpl(final CyNetworkFactory cnf, final
CyNetworkViewFactory cnvf,
final CyNetworkManager netMgr, final
CyNetworkViewManager networkViewManager,
final CyNetworkNaming namingUtil, final
SynchronousTaskManager<?> syncTaskMgr,
@@ -66,13 +64,17 @@
}
public TaskIterator createTaskIterator() {
- task = new NewEmptyNetworkTask(cnf, cnvf, netMgr,
networkViewMgr, namingUtil, vmm);
- return new TaskIterator(task);
+ return new TaskIterator(createTask());
}
+ private NewEmptyNetworkTask createTask() {
+ return new NewEmptyNetworkTask(cnf, cnvf, netMgr,
networkViewMgr, namingUtil, vmm);
+ }
+
public CyNetworkView createNewEmptyNetworkView() {
// no tunables, so no need to set the execution context
- syncTaskMgr.execute(createTaskIterator());
+ NewEmptyNetworkTask task = createTask();
+ syncTaskMgr.execute(new TaskIterator(task));
return task.getView();
}
}
--
You received this message because you are subscribed to the Google Groups
"cytoscape-cvs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/cytoscape-cvs?hl=en.
