Branch: refs/heads/master
Home: https://github.com/cytoscape/cytoscape.js
Commit: e2bdfae4f7d762383888da65573fc6e70052f38d
https://github.com/cytoscape/cytoscape.js/commit/e2bdfae4f7d762383888da65573fc6e70052f38d
Author: Alexandre Fonseca <[email protected]>
Date: 2016-02-25 (Thu, 25 Feb 2016)
Changed paths:
M src/extensions/renderer/base/load-listeners.js
Log Message:
-----------
Fix taphold and cxttap problems under Chrome for Windows.
Use desktopTapThreshold for all mouse drag functionality.
Related external bugs:
https://bugs.chromium.org/p/chromium/issues/detail?id=161464
Because of the aforementioned bug in Chromium (which apparently only affects
Windows users), all events that rely on there not being a `mousemove` event,
such as `taphold` and `cxttap` (these were the only 2 I tested), fail to
trigger.
As pointed out in the external bug report, a simple solution and good practice
when dealing with these click + move interactions is to only consider a drag
after a certain movement threshold (> 0 is enough to address the chrome bug).
Looking at the documentation, such a threshold apparently already exists
(`desktopTapThreshold`) but is only applied when testing dragging of nodes.
Commit: 575285a9ed62a40e3c957a734bea98da8f43cf6a
https://github.com/cytoscape/cytoscape.js/commit/575285a9ed62a40e3c957a734bea98da8f43cf6a
Author: Max Franz <[email protected]>
Date: 2016-03-01 (Tue, 01 Mar 2016)
Changed paths:
M src/extensions/renderer/base/load-listeners.js
Log Message:
-----------
Merge pull request #1269 from AlexJF/dragThreshold-chromefix
Fix taphold and cxttap problems under Chrome for Windows.
Compare:
https://github.com/cytoscape/cytoscape.js/compare/a6f0919884c5...575285a9ed62
--
You received this message because you are subscribed to the Google Groups
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/cytoscape-cvs.
For more options, visit https://groups.google.com/d/optout.
