Branch: refs/heads/3.6.x
  Home:   https://github.com/cytoscape/cytoscape.js
  Commit: 25f956e0cd64941ee02cb23b114816adb513c12f
      
https://github.com/cytoscape/cytoscape.js/commit/25f956e0cd64941ee02cb23b114816adb513c12f
  Author: Max Franz <[email protected]>
  Date:   2019-06-06 (Thu, 06 Jun 2019)

  Changed paths:
    M src/style/apply.js
    M test/collection-style.js

  Log Message:
  -----------
  Function mapper performance check requires null check for some props

Some properties, like `control-point-distances`, do not have non-null default 
values to fall back on.  These properties are typically override properties:  
The property overrides the behaviour of another one and the `null` value 
indicates that the behaviour override is inactive.  Because most properties do 
have a default value, it's very subtle.  The performance enhancement in #2239 
assumes that all properties have a default value, missing the null check.  This 
causes the issue.

Ref : When applying a function mapper to control-point-distances, eleProp is 
null in applyContextStyle() #2423 #2427

Ref : Optimizations for mapped style properties #2239


-- 
You received this message because you are subscribed to the Google Groups 
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/cytoscape-cvs.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/3.6.x/b085c1-25f956%40github.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to