Branch: refs/heads/master
Home: https://github.com/cytoscape/cytoscape.js
Commit: 7e365e25e0b9eb11e12f92af4826bc1d3f679dde
https://github.com/cytoscape/cytoscape.js/commit/7e365e25e0b9eb11e12f92af4826bc1d3f679dde
Author: Max Franz <[email protected]>
Date: 2019-06-20 (Thu, 20 Jun 2019)
Changed paths:
M src/extensions/renderer/base/coord-ele-math/rendered-style.js
Log Message:
-----------
Use a separate `cleanConnected` flag to track whether the edges connected to
a node have been handled by a previous dirtying of the node bounds.
Re-using the same `clean` flag for both the node itself and the connected edges
is problematic in the case where the rendered style for the node is updated
mid-tick. This can happen when the bounding box is queried, such as for a fit
operation during a layout. Though we should allow the rendered style for the
node itself to be updated right away in cases like this, we need to make sure
that the edges still effectively get enqueued for rendered style calculation.
It is not sufficient to also update the edges immediately during a mid-tick
update on a node. That would cause redundant calculations on edges in many
cases, and edges are already expensive. Using the extra flag suffices to
lazily enqueue the edges at the end of each tick.
Ref : A bounding box query can cause connected edges to not have rendered style
updated (e.g. endpoints) #2440
--
You received this message because you are subscribed to the Google Groups
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/cytoscape-cvs.
To view this discussion on the web visit
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/master/bce688-7e365e%40github.com.
For more options, visit https://groups.google.com/d/optout.
