Branch: refs/heads/master
Home: https://github.com/cytoscape/cytoscape.js
Commit: 23a6a1aa7ea2bad746cbd5e0994b3842cf86c22d
https://github.com/cytoscape/cytoscape.js/commit/23a6a1aa7ea2bad746cbd5e0994b3842cf86c22d
Author: Max Franz <[email protected]>
Date: 2019-07-17 (Wed, 17 Jul 2019)
Changed paths:
M src/collection/dimensions/bounds.js
Log Message:
-----------
Use an alternative approach to the bounds consistency issue.
- Remove `takesUpSpace()` check from `updateCompoundBounds()` completely. This
removes the expense of doing the filter, and it should have the same net effect
if `boundingBox()` omits zero-area elements.
- Make the `displayed` flag in `boundingBox()` check only the `display`
property. For an edge, also check the connected nodes to be consistent with
`takesUpSpace()`. This avoids infinite recursion for compound graphs. A
compound graph would otherwise call `updateCompoundBound()`, `boundingBox()`,
`width()`, `updateCompoundBounds()`, ...
- Remove the unused `updated` array for `updateCompoundBounds()`.
Ref : Bounds calculation is inconsistent re. zero-area (or hidden) elements
#2472
--
You received this message because you are subscribed to the Google Groups
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/cytoscape-cvs.
To view this discussion on the web visit
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/master/adda2d-23a6a1%40github.com.
For more options, visit https://groups.google.com/d/optout.
