Branch: refs/heads/unstable
Home: https://github.com/PathwayCommons/factoid
Commit: 761cc55c87503c00c7275049321c8eea6db119ab
https://github.com/PathwayCommons/factoid/commit/761cc55c87503c00c7275049321c8eea6db119ab
Author: Max Franz <[email protected]>
Date: 2019-11-12 (Tue, 12 Nov 2019)
Changed paths:
M README.md
M package-lock.json
M package.json
A src/client-env-vars.json
M src/client/components/editor/cy/defs.js
M src/client/components/editor/cy/stylesheet.js
M src/client/components/editor/index.js
M src/client/components/element-info/interaction-info.js
M src/client/components/popover/popover.js
A src/client/components/share.js
M src/config.js
M src/model/document/document.js
M src/server/index.js
M src/server/routes/api/document/index.js
M src/server/routes/index.js
M src/server/routes/style-demo.js
M src/styles/base.css
M src/styles/custom-icons.css
M src/styles/editor/editor.css
A src/styles/image/icon-twitter.svg
M src/styles/index.css
A src/styles/share.css
M src/util/cy.js
R src/views/index.html
A src/views/index.html.ejs
M webpack.config.js
Log Message:
-----------
Share to Twitter
Add shareable summary support for Twitter:
- Twitter card support has been added. To support this feature, dynamic meta
tags must be available on the initial HTTP response for the `/document/:id`
page. These meta tags are generated by server-side EJS templates on index.html.
- One of the Twitter card meta tags is a reference to the image for the card.
This is supported by server-side image generation using Cytosnap at the
`/api/document/:id.png` route. The use of Cytosnap required pulling out the
base Cytoscape stylesheet as a JSON-serialisable object.
- The readme has been updated to include share-related environment variables.
There are some unrelated variables that are undocumented. They should be
documented as a part of #575.
- Improvements to the read-only view will be part of a different PR in
conjunction with data changes related to the admin panel #524.
- The "Share" button in the editor is now more salient. This should help
encourage users to click the button when they're finished editing their
documents. It also matches the Twitter style of buttons to be more familiar to
users.
Other, related changes:
- Update Cytoscape to 3.12.0 (latest).
- The Cytoscape stylesheet code is accessible from the client or the server
under `util`.
- Environment variables are handled more consistently between the server and
the client now. All variables available to the client are defined in
`src/client-env-vars.json`. You can `import` the variables from `config.js` on
the client now. Before they would not be dynamic unless you used a
`process.env.VAR_NAME` string to refer to `VAR_NAME` in the client-side source
code. There is a preliminary list of variables in that JSON file, but we'll
have to test and reevaluate.
Ref : Shareable summary #542
Commit: 5b07ab427af57158c2a476aa92d93a39ec235540
https://github.com/PathwayCommons/factoid/commit/5b07ab427af57158c2a476aa92d93a39ec235540
Author: Jeffrey <[email protected]>
Date: 2019-11-12 (Tue, 12 Nov 2019)
Changed paths:
M README.md
M package-lock.json
M package.json
A src/client-env-vars.json
M src/client/components/editor/cy/defs.js
M src/client/components/editor/cy/stylesheet.js
M src/client/components/editor/index.js
M src/client/components/element-info/interaction-info.js
M src/client/components/popover/popover.js
A src/client/components/share.js
M src/config.js
M src/model/document/document.js
M src/server/index.js
M src/server/routes/api/document/index.js
M src/server/routes/index.js
M src/server/routes/style-demo.js
M src/styles/base.css
M src/styles/custom-icons.css
M src/styles/editor/editor.css
A src/styles/image/icon-twitter.svg
M src/styles/index.css
A src/styles/share.css
M src/util/cy.js
R src/views/index.html
A src/views/index.html.ejs
M webpack.config.js
Log Message:
-----------
Merge pull request #583 from PathwayCommons/share-to-twitter
Share to Twitter
Compare:
https://github.com/PathwayCommons/factoid/compare/65ab97e042d5...5b07ab427af5
--
You received this message because you are subscribed to the Google Groups
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/cytoscape-cvs/PathwayCommons/factoid/push/refs/heads/unstable/65ab97-5b07ab%40github.com.
