Carl Karsten wrote: > Paul McNett wrote: >> dabo Commit >> Revision 2737 >> Date: 2007-01-22 14:06:31 -0800 (Mon, 22 Jan 2007) >> Author: Paul >> >> Changed: >> U trunk/dabo/biz/dBizobj.py >> U trunk/dabo/biz/test/test_dBizobj.py >> U trunk/dabo/db/dBackend.py >> U trunk/dabo/db/test/test_dCursorMixin.py >> >> Log: >> Added more tests to dBizobj, after I realized that after a biz.saveAll(), the >> current row number wasn't being restored if the pk is auto-generated by the >> backend. Fixed in dBizobj: used RowNumber instead, which doesn't change >> after >> a save. >> >> Made dBackend raise a ValueError if AutoCommit can't be set. Added >> appropriate >> test for this case in the dCursorMixin test. >> >> Fixed up the dCursorMixin test to mostly work with firebird. This required >> changing all the field names to lower from mixed-case, as firebird returns >> all case-insensitive names as UPPER, and dabo lower()s it, and Python is >> case-sensitive. I think in the future we need to define a case-insensitive >> string type to use for field and table names as appropriate, but for now this >> will do. > > Why does dabo lower() the field names?
As far as I can see, it only does it in Firebird, presumably because Firebird will return one of: + UPPER name, which is case-insensitive to Firebird + CaseSensitive name and Python is always case sensitive. Perhaps it is just that we thought UPPER was uglier than lower. In any case, I didn't want to change anything because I wasn't the one to put in dbFirebird to begin with, I don't have a Firebird server to test against, and there may be reasons I don't know about that we are lower()ing the field names. But... I think the right thing to do is to not mangle the field names as returned by Firebird. However, we still need to deal with the CaseSensitive names which is a much larger problem. So for now, we stick with status quo. -- pkm ~ http://paulmcnett.com _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
