Ed Leafe wrote: > On Aug 23, 2007, at 3:31 PM, Uwe Grauer wrote: > >> Would you please tell us why you changed the logic in >> dbFirebird.getFields() to use a dCursorMixin class instead of the >> plain >> kinterbasdb cursor like it was before? > > Because we were getting errors that indicated that the cursor object > was not able to determine its database. This was to ensure that the > same cursor/connection that was accessing the data was also accessing > the database. > >> I don't see why it was necessary to use a dCursorMixin class as i'm >> not >> able to think of the real reason for this. > > I may end up reverting these changes, since it appears that the main > problem was with SQLite's transactions handling, as well as its > cryptic error messages. > >> Unfortunately you didn't change the following logic, so it's messed >> up now. > > Well, that's what happens when you make major changes to complex > frameworks. The way that transactions are handled permeates the > entire db layer, so I would expect these sorts of problems when such > a large change is made. For now I've corrected the problem, which was > simply due to the fact that we were getting back dicts instead of > tuples. >
I can confirm that with rev 3328 it works again. I didn't have any problems with using dCursorMixin cursors as a parameter to call getFields, but didn't understand why it was used inside of getFields(). getFields() was more optimized before (with the use of a kinterbasdb cursor). I still don't see why the overhead of using dCursorMixin inside of getFields is necessary. There is nothing in getFields() which would have to be quoted because we are using hand-made sql here. So my question of why it would make sense to replace the kinterbasdb cursor by a higher level cursor class still remains. _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/dabo-dev/[EMAIL PROTECTED]
