On Aug 9, 2008, at 10:47 PM, Paul McNett wrote:

> IMO each commit should ideally be one thing. So ideally we would have
> had the grid editor commit, the renaming of dFoldPanel commit, and the
> changes to the dSlidePanelControl/dSlidePanel commit.

        Ideally, I agree. But I have been working on these in independent  
bursts in between being swamped at work. Since both the grid and slide  
control changes involved __init__.py, it was difficult to separate them.

> Just reinforces my point: you didn't list the improvements, and I  
> can't
> even easily look at a diff because the commit to move the file was the
> same revision as the changes made.

        It's mostly because a) I did this over a 3-week period, and don't  
keep notes and b) I re-thought out a lot of the underpinning of the  
classes without too many overt visual/practical changes. Example: the  
handling of the caption bar makes the use of sizers almost impossible;  
the FoldPanelBar class from Andrea only allowed for adding items in a  
vertical stack. I figured out a way to make this work, but it still  
occasionally shows some odd resizing/layout effects.

-- Ed Leafe





_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message: http://leafe.com/archives/byMID/%(messageid)s

Reply via email to