On Thu, Mar 12, 2009 at 9:02 AM, Paul McNett <[email protected]> wrote: > Uwe Grauer wrote: >> Nate Lowrie wrote: >>> On Thu, Mar 12, 2009 at 7:44 AM, Uwe Grauer >>> <[email protected]> wrote: >>>> Seems that flatenotebook included in dPageFrame isn't always part >>>> of wxPython. >>>> It got included after there was an enhancement request in: >>>> http://trac.dabodev.com/ticket/1022 >>>> >>>> See thread "Do Editra and XRCed belong to wxPython?" in wxpython-dev. >>>> >>>> I don't know what to do about the issue. >>>> faltnotebook shoud either be dropped or included into Dabo. >>> Uwe, >>> >>> Fact is, the Editra version fixes some display problems with the nav >>> buttons under certain display flag settings. That was the only reason >>> I used it over the standard FNB implementation, because a client >>> needed the changes. I don't see a problem using it and it's been in >>> Dabo for almost a year now. If Editra is not in a future wx version, >>> we can deal with it then. I can't reproduce any import errors with >>> 2.8.9.2 and it's not harming anything by being there. Can you provide >>> a logical justfication about why we should remove it? >> >> As you wrote in your previous mail, flatenotebook is located in >> wx.lib.agw too. I didn't know this. >> The current import is: >> ./dabo/ui/uiwx/dPageFrame.py: import wx >> .tools.Editra.src.extern.flatnotebook as fnb >> >> So this should at least be changed to the one in wx.lib.agw (if it is >> the same). >> The reason is that not all package maintainers include Editra as >> wx.tools.Editra but instead package Editra standalone. > > We should do a diff to compare those two versions, and take it upon ourselves > to > submit a patch to Andrea and/or Robin to get Cody's necessary changes into the > wxPython version of the control. > > Then we can deprecate the Editra import, and start using the wx.lib.agw one.
Agreed. _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[email protected]
