On Mar 18, 2009, at 5:44 AM, Pedro Vale de Gato wrote:
> Make virtualField text search case insensitive
I'm currently buried with work between my job and preparing for PyCon
next week, so I haven't been able to play with your changes. One
observation that I did make by scanning the diff is just an efficiency
issue: you calculate the same value many times instead of just once.
Example: in scanVirtualFields, you calculate op.lower() 9 times. It's
much cleaner and efficient to just do it once.
oplow = op.lower()
if oplow in ("eq", "equals", "="):
if virtValue == expr:
self.__filterPKVirtual.append(self.getFieldVal(self.KeyField))
elif oplow in ("ne", "nequals", "!="):
... etc.
-- Ed Leafe
_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message:
http://leafe.com/archives/byMID/[email protected]
