Paul, I don't think so. What I wanted to do was to return only if beingpage() was actually called. You are setting isNewPageOrColumn = True and then tesing "if isNewPageOrColumn" without it possibly changing in between so the "return y" will never get fired. Was my change incorrect?
Larry > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Paul McNett > Sent: Friday, October 16, 2009 3:06 PM > To: [email protected] > Subject: [dabo-dev] dabo Commit 5470 > > dabo Commit > Revision 5470 > Date: 2009-10-16 12:06:10 -0700 (Fri, 16 Oct 2009) > Author: Paul > Trac: http://trac.dabodev.com/changeset/5470 > > Changed: > U trunk/dabo/lib/reportWriter.py > > Log: > Working off Larry's latest patch in ticket #1281, I > determined that Carl's report skipped a detail record when > moving to the next column. > > Does this fix it? > > > Diff: > Modified: trunk/dabo/lib/reportWriter.py > =================================================================== > --- trunk/dabo/lib/reportWriter.py 2009-10-15 23:08:01 UTC > (rev 5469) > +++ trunk/dabo/lib/reportWriter.py 2009-10-16 19:06:10 UTC > (rev 5470) > @@ -1852,8 +1852,9 @@ > > check = pageFooterOrigin[1] + > pfHeight + extraHeight > > + isNewPageOrColumn = False > if y < check or maxBandHeight is None: > - headers_printed = False > + isNewPageOrColumn = True > if self._currentColumn > >= columnCount-1: > > self.being_deferred = True > endPage() > @@ -1861,15 +1862,12 @@ > beginPage() > y = pageHeaderOrigin[1] > y = > reprintGroupHeaders(y) > - headers_printed = True > else: > self._currentColumn += 1 > y = pageHeaderOrigin[1] > maxBandHeight = > getTotalBandHeight() > > - if band in ("detail", > "groupFooter") and not headers_printed: > - y = > reprintGroupHeaders(y) > - if band != "detail" and > headers_printed: > + if not isNewPageOrColumn: > return y > > if not deferred: > > > > [excessive quoting removed by server] _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/!~!uenerkvcmdkaaqacaaaaaaaaaaaaaaaaabgaaaaaaaaaafa2fnyupuomnfpiynbeqckaaaaqaaaafkgo+qchkecnmpvp+3ve3qeaa...@charter.net
