In r4923 about 1.5 years ago, this change was made to getFieldVal(), but I'm
wondering about the rationale (whitespace reformatted for email):
{{{
if cursor is not None:
- ret = cursor.getFieldVal(fld, row, _rowChangeCallback=changeRowNumCallback)
+ try:
+ ret = cursor.getFieldVal(fld, row, _rowChangeCallback=changeRowNumCallback)
+ except dException.RowNotFoundException:
+ return None
}}}
So, if the row isn't found, None is returned, which seems ambiguous (a good
field
value could return None, too).
I see that, historically, we return None by default if other things go wrong,
too,
and I'm just wondering if we shouldn't just be raising or re-raising the
appropriate
exception.
Thoughts?
Paul
_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message: http://leafe.com/archives/byMID/[email protected]
