On 10/17/10 12:37 PM, Ed Leafe wrote: > On Oct 17, 2010, at 12:30 PM, Paul McNett wrote: > >>> I think we should do away with 'from settings import *' and that code should >>> reference 'dabo.settings'. >> >> I see that my answer conflicted with Ed's. Ed, do you feel strongly either >> way? > > > Strongly? No. But I do remember that the values in settings were > originally in __init__.py and were moved to settings.py as a way to separate > out the stuff that users can override from the stuff that they shouldn't > touch: the whole settings_override.py design. They were always simple > attributes of the dabo module, so when we refactored them out, we added the > 'from settings import *' to keep them that way. Conceptually, though, they > are attributes of the dabo namespace, and referencing them like that seems a > lot cleaner.
Taking everything into consideration, the most important being not breaking long-working code, we should leave the attributes as they are (dabo.dateFormat). But perhaps we should make it harder for people to use dabo.settings. Paul _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[email protected]
