Most of the Phoenix changes were left in unless they specifically caused an issue with classic (big nod to dGrid here, which John reverted entirely to master's file due to many issues). The exception to this rule was the file name changes, which I reverted due to concerns about compatibility with existing applications. However, if going forward there are good reasons to go with the new file names and we reach consensus on this, re-applying them shouldn't be a major ordeal. The main thing would be checking for regressions.
I agree it would be best to keep compatibility with classic and Phoenix together in one distribution. In the short term, based on what I've seen of existing Phoenix changes I think this should be possible. However, I do fear for what will happen in the long term as Phoenix starts to stray further away from classic - ultimately you would end up with a progressively uglier code base or be forced to drop support for classic entirely. The only other option I could think of would be to consider them as two fundamentally different toolkits located in two different subfolders of dabo.ui. Neil On February 24, 2015 11:09:36 AM PST, john <[email protected]> wrote: >I hope we haven't done that - I mean the code should run on all >supported platforms (Linux, windows, MAC). There are still issues >-Linux can't run the reportDesigner (although the reported splash bugs >works for my Linux), The Mac had issues with Autocomplete, and a few >other minor issues like the dLine, the windows now appears to have >almost everything - Neil might correct me here. > >That siad, having been involved with the process there was much that >was >broken just moving from 2.8.x to 3.x with wxPython. Neil had only so >much time and I believe the code provided could be changed to include >Phoenix. So I decided to not try and cover 2.8.x . I'm sure the code >will not work with 2.8.x and to get it there would be a mess. > >Johnf > >On 02/24/2015 10:33 AM, Paul McNett wrote: >> Thank you gentlemen for trying hard to sort it all out. One thing I >do >> know, we really don't want separate forks for different environments. > >> We must avoid that at all costs. >> >> Paul >> >> >> On 2/24/15 10:30 AM, Werner wrote: >>> Hi John, >>> >>> On 2/24/2015 18:43, john wrote: >>>> I'm sorry about that - but I decided along with Neil that it was >best >>>> to get wxPython 3.x working since it was stable and fixes were >being >>>> posted. As a result of the decision much of your code was >>>> reversed/removed. >>> That is what I still don't understand. Was it done so code would >stay >>> compatible with existing Dabo applications or was it done because my >>> change caused a problem? >>>> That said, I believe it is possible in the future to bring Phoenix >in >>>> when it becomes stable. Or we could have three versions Dabo .9, >>>> Dabo2, Dabo3 where two = wxPython3 and three = Phoneix (I'm sure >>>> wxPython .X will be the name). >>> I was and am still hoping that the code in 'phoenix-2ndtry' would >work >>> with wxPython 3 classic and wxPython 3 phoenix and should really >still >>> work with wxPython 2.8 classic. BUT it requires that applications >using >>> it change from the dFrame.py to the frame.py etc. >>>> >>>> Have you been able to test the commit - like your report writing >stuff? >>> Yes, did a bit of testing and it seems to work. So, wanted to see >why >>> it does and the 'phoenix-2ndtry' does not work, but to try to see >the >>> changes just in dGrid.py in your code and grid.py in >'phoenix-2ndtry' is >>> not easy and some changes I don't know where they come from. >>> >>> Will see if I find more time over the next few days >>> >>> Werner >>>> >>>> Johnf >>>> On 02/24/2015 01:37 AM, Werner wrote: >>>>> That rename makes it also difficult to see what changes John and >Neil >>>>> have done when doing a diff of the folders:-( to see what could >be >>>>> reused from their work on the 'phoenix-2ndtry' branch. >>>> >>>> [excessive quoting removed by server] _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://mail.leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[email protected]
