Jacek Kałucki wrote: > Hi, > I have two questions related with dFormMixin class methods/events: > 1) why in __onClose event, calling closing() function is "force" variable > value dependent, and in close() method, this function is unconditionally > called, > regardless of "force" is true or false, is't it incoherency? > 2) why only in __onClose event, _isClosed property is set, but in > close() method isn't?
There's some refactoring to do in these two methods, certainly. __onClose() is going to be called no matter what, unless the user overrides with their own event handler, while close() is something available to the appdev to call. But in normal situations, calling form.close() will also result in form.__onClose() being run. So there's going to be duplication of code running. At least that's how I read it. I think this needs some cleanup, and not just the inconsistency you note. Paul _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-users Searchable Archives: http://leafe.com/archives/search/dabo-users This message: http://leafe.com/archives/byMID/[email protected]
