demerphq wrote:
On 6/21/06, Steve Peters <[EMAIL PROTECTED]> wrote:
On Wed, Jun 21, 2006 at 09:07:35AM +0100, Steve Hay wrote:
> Steve Hay wrote:
> >Automated smoke report for 5.9.4 patch 28410
> >Mugwump.uk.radan.com: Intel(R) Pentium(R) 4 CPU 3.40GHz(~3391 MHz)
(x86/2
> >cpu)
> > on MSWin32 - WinXP/.Net SP2
> > using cl version 12.00.8804
> > smoketime 6 hours 57 minutes (average 10 minutes 26 seconds)
> >
> >Summary: FAIL(Fm)
> >
> >..\regcomp.c(5183) : error C2143: syntax error : missing ';' before
'type'
>
> Broken by change 28405, fixed by change 28412.
>
> "PERL_UNUSED_ARG(depth);" expands to "((void)depth);", so it's the old
> code before declarations thing which VC++ doesn't allow again.
>
> I thought warnings levels for compilers on (some) other systems had
been
> set to spot these? Did I dream that?
>
gcc should, but didn't seem to when I compiled. gcc must not be able to
recognize this kind of case.
PERL_UNUSED_ARG cant be used before a GET_RE_DEBUG_FLAGS_DECL;
This patch isn't strictly required. They're all cases like:
#ifndef DEBUGGING
PERL_UNUSED_ARG(arg);
#endif
GET_RE_DEBUG_FLAGS_DECL;
When DEBUGGING that expands to:
IV re_debug_flags = 0; GET_RE_DEBUG_FLAGS;
and when not DEBUGGING it expands to:
((void)arg);
so there's no problem :-)
However, I agree that it is a little risky having it work purely on the
basis of how the #ifdef's work out so putting things the right way round
seems like a good move.
Applied as #28414. Thanks!
--
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should check
it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
