On Wed 17 Nov 2004 04:57, "H.Merijn Brand" <[EMAIL PROTECTED]> wrote:
> Return-Path: <[EMAIL PROTECTED]>
> ______________________________________________________________________________
> Automated smoke report for 5.9.2 patch
> pc03: x86 Family 15 Model 1 Stepping 2, GenuineIntel (x86/1 cpu)
> on cygwin_nt-5.0 - 1.5.12(0.116/4/2)
> using ? gcc version 3.3.3 (cygwin special)
> smoketime (average )
>
> Summary: PASS
>
> O = OK F = Failure(s), extended report at the bottom
> X = Failure(s) under TEST but not under harness
> ? = still running or test results not (yet) available
> Build failures during: - = unknown or N/A
> c = Configure, m = make, M = make (after miniperl), t = make test-prep
>
> Configuration (common)
> ----------- ---------------------------------------------------------
> | | | +----- PERLIO = perlio -DDEBUGGING
> | | +------- PERLIO = stdio -DDEBUGGING
> | +--------- PERLIO = perlio
> +----------- PERLIO = stdio
>
>
> --
> Report by Test::Smoke v1.19 build 777 running on perl 5.9.2
> (Reporter v0.018 / Smoker v0.016)
To prevent reports like this I propose, thouhg using Reporter and the counts
from _parse might be safer:
--- TS-1.19/lib/Test/Smoke/Mailer.pm 2004-04-30 18:24:07.000000000 +0200
+++ smoke/Test/Smoke/Mailer.pm 2004-11-17 10:25:20.523078768 +0100
@@ -122,6 +122,7 @@ sub fetch_report {
if ( open REPORT, "< $report_file" ) {
$self->{body} = do { local $/; <REPORT> };
close REPORT;
+ $self->{body} =~ m/\n-+\s+-+\n\|(\s+\|)*\s+\+--/ and return "";
} else {
require Carp;
Carp::croak "Cannot read '$report_file': $!";
@@ -246,7 +247,7 @@ program.
sub mail {
my $self = shift;
- my $subject = $self->fetch_report();
+ my $subject = $self->fetch_report() or return $self->{error} = "No test
results";
my $cc = $self->_get_cc( $subject );
my $header = "To: $self->{to}\n";
$header .= "From: $self->{from}\n"
@@ -315,7 +316,7 @@ sub mail {
my $mailer = $self->{mailbin} || $self->{mailxbin};
- my $subject = $self->fetch_report();
+ my $subject = $self->fetch_report() or return $self->{error} = "No test
results";
my $cc = $self->_get_cc( $subject );
my $cmdline = qq|$mailer -s '$subject'|;
@@ -385,7 +386,7 @@ sub mail {
$self->{error} = $@ and return undef;
- my $subject = $self->fetch_report();
+ my $subject = $self->fetch_report() or return $self->{error} = "No test
results";
my $cc = $self->_get_cc( $subject );
my %message = (
@@ -456,7 +457,7 @@ sub mail {
$self->{error} = $@ and return undef;
- my $subject = $self->fetch_report();
+ my $subject = $self->fetch_report() or return $self->{error} = "No test
results";
my $cc = $self->_get_cc( $subject );
my %message = (
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.5, & 5.9.x, and 809 on HP-UX 10.20 & 11.00, 11i,
AIX 4.3, AIX 5.2, SuSE 9.1, and Win2k. http://www.cmve.net/~merijn/
http:[EMAIL PROTECTED]/ [EMAIL PROTECTED]
send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org
