On Tue, Aug 02, 2005 at 01:57:42PM +0200, Erik Schnetter wrote:
> On Tuesday 02 August 2005 13:34, David Roundy wrote:
> > On Mon, Aug 01, 2005 at 08:39:45PM -0400, Matt Lavin wrote:
> > > Here's a pretty simple test and fix for bug 463.  I also noticed
> > > that bug 194 seems to be fixed but the ticket is still open.
> > >
> > > Mon Aug  1 20:21:16 EDT 2005  Matt Lavin <[EMAIL PROTECTED]>
> > >   * fix for bug 463 (with new test)
> >
> > Thanks for the bugfix! (and I've now also resolved 194.)
> >
> > > hunk ./Add.lhs 256
> > > -             return $ f: map (\f'->f++"/"++f') fs
> > > +             return $ f: map (\f'-> join f f') fs
> > > +          where join base ('.':'/':rest) = join base rest
> > > +                join base dir = base ++ "/" ++ dir
> >
> > Note that this is a nice opportunity for the inline syntax:
> >
> >   return $ f: map (`join` f') fs
> 
> Isn't f' undefined in that case?  Shouldn't that be
> 
>     return $ f: map (join f) fs
>
> instead?  That would be a partial function application (aka cut), not an 
> inline operator.

Right, my mistake.  Or for those of us who are keen on inline versions of
functions  :)

  return $ f: map (f `join`) fs

(which uses two extra characters, so it's not really an improvement unless
one really likes inline functions)
-- 
David Roundy
http://www.darcs.net

Attachment: signature.asc
Description: Digital signature

_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to