On Mon, Aug 29, 2005 at 07:53:21AM -0400, David Roundy wrote:
> 
> hunk ./FastPackedString.hs 849
>                       $ \p -> hGetBuf h p blocksize
>                case lread of
>                    0 -> return []
> +                  l | l < blocksize -> do hClose h
> +                                          return [PS fp 0 l]
>                    l -> do rest <- unsafeInterleaveIO read_rest
>                            return (PS fp 0 l:rest)
>        unsafeInterleaveIO read_rest

While this looks correct, I think it will mean that some bugs are harder
to find, as you need to have (>1000) files that are larger than the
buffer size, or perhaps are a multiple of the buffer size, to trigger
them.

I don't think it'll actually solve any bugs, just some instances of
them.


Thanks
Ian


_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to