This patch adds a --subject flag to 'darcs send'.
It includes updated documentation and a small test.
Notice that due to the magic of 'darcs replace', this patch applies
regardless of whether my other darcs send patch [*] has been applied,
even though they touch the same lines.
[*] I recently sent another patch to the list which bases the default
subject on the latest rather than the earliest patch in the bundle.
Mon Dec 5 13:03:01 CET 2005 Joeri van Ruth <[EMAIL PROTECTED]>
* Add --subject flag to 'darcs send'
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
New patches:
[Add --subject flag to 'darcs send'
Joeri van Ruth <[EMAIL PROTECTED]>**20051205120301] {
hunk ./DarcsArguments.lhs 28
- - logfile, rmlogfile, from_opt,
+ logfile, rmlogfile, from_opt, subject, get_subject,
hunk ./DarcsArguments.lhs 174
- - unified, summary, compress, uncompress, uncompress_nocompress,
+ unified, summary, compress, uncompress, uncompress_nocompress, subject,
hunk ./DarcsArguments.lhs 593
+
+\begin{code}
+subject = DarcsArgOption [] ["subject"] Subject "SUBJECT" "specify mail subject"
+get_subject :: [DarcsFlag] -> Maybe String
+get_subject (Subject s:_) = Just s
+get_subject (_:fs) = get_subject fs
+get_subject [] = Nothing
+\end{code}
hunk ./DarcsFlags.lhs 25
- - | Target String | Cc String | Output String
+ | Target String | Cc String | Output String | Subject String
hunk ./Send.lhs 29
- - edit_description, sign,
+ edit_description, sign, get_subject,
replace ./Send.lhs [A-Za-z_0-9] subject auto_subject
hunk ./Send.lhs 31
- - output, cc, target, author, sendmail_cmd,
+ output, cc, subject, target, author, sendmail_cmd,
hunk ./Send.lhs 89
- - target,cc,output,sign,
+ target,cc,subject,output,sign,
hunk ./Send.lhs 163
+ let thesubject = case get_subject opts of
+ Nothing -> auto_subject to_be_sent
+ Just subj -> subj
hunk ./Send.lhs 167
- - sendEmailDoc from (lt thetargets) (auto_subject to_be_sent) (get_cc opts)
+ sendEmailDoc from (lt thetargets) (thesubject) (get_cc opts)
hunk ./Send.lhs 204
+
+\begin{options}
+--subject
+\end{options}
+
+Use the \verb!--subject! flag to set the subject of the e-mail to be sent.
+If you don't provide a subject on the command line, darcs will make one up
+based on names of the patches in the patch bundle.
+
hunk ./Send.lhs 295
- -values. Accepted format specifiers are \verb!%s! for auto_subject, \verb!%t! for to,
+values. Accepted format specifiers are \verb!%s! for subject, \verb!%t! for to,
hunk ./Send.lhs 303
- -evolution "mailto:%T?auto_subject=%S&attach=%A&cc=%C&body=%B"
+evolution "mailto:%T?subject=%S&attach=%A&cc=%C&body=%B"
hunk ./tests/send.sh 29
+
+# Test that the --subject parameter sets the subject
+$DARCS send --author=me -a --subject="it works" "--sendmail-command=cat %<" ../temp2 | grep -x "Subject: it works"
}
Context:
[TAG 1.0.5rc1
Tommy Pettersson <[EMAIL PROTECTED]>**20051125191739]
Patch bundle hash:
a46a34b2f4273e1837afaf8bf5f56e8ae775951c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iQEVAwUBQ5Q6p0R4+U85jGvKAQJCGgf/T6kIurL49iNkXVW1zCm0okP1m1GDciQY
VfmWPtdv+QSZmxDJBjpsrK9xmtB/PUs4TDYwfoEhHDcbB4ZyKrdoZ8ZRfK0AsiqS
dinfpKPG8gEHqLpd8KZnXD60RuoOujR+uW6Q8yjsmJ8k0qUcUxed4M3lJLJlQEZc
sx1S+/YOAcvGffSIA3/tLVHGwN81hmUbu38no8gX922E0sX91aQM5hQVxHZBcbhv
IliKhtlrcpPPCAQf+STiCJiUiDWh6n2MtFHG/9MqpinBXa6JccUsacVA2Ramf11T
Pz0u9zIOvaQJ8MqjvPiRSiRdIHR3rEHWHSbGcdqli/3ARzEFTvfx6g==
=QTIm
-----END PGP SIGNATURE-----
_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
