On Sat, Jan 14, 2006 at 04:24:16AM -0800, Jason Dagit wrote: > > I was looking a issue80 and I discovered that Repository.writePatch > reads the freshly written patch. This is a very expensive operation > given the current patch format. So I started to wonder why it does > that.
To avoid the data all being kept in memory. > As an experiment I removed the reading the patch and just let > Repository.writePatch return the same patch it was given. On a test > case of recording a 37meg file I went from 39 seconds for the record > to just 3.9 seconds. Total memory allocated during the run when from > 3.5 gigs to 444 megs. This is a very significant savings. The peak memory usage is far more important. "darcs record -a" ought to be a constant space operation. As you imply, the 39s vs 3.9s ratio is likely to reduce when we use the new patch format, so it seems premature to optimise for it. Thanks Ian _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
