On 1/16/06, Juliusz Chroboczek <[EMAIL PROTECTED]> wrote:
> > I suppose I'll change the option name to --references as well.
>
> Oh, I didn't notice that.  Yuck.  What about
>
>     darcs send \
>         --mail-header "References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>" \
>         --mail-header "In-reply-to: <[EMAIL PROTECTED]>" \
>         --mail-header "Precedence: bulk"
>
> In other words, the --mail-header flag is allowed multiple times, and
> each instance adds a new header to the message.  Order should be
> preserved, so we can add order-sensitive headers too (yes, there are
> some).

I like this.  It is a bit lower level, but so is specifying a message
id to reply to, so I think it is okay. I'll update the patch.

> There should also be a --discard-mail-header flag, that discards all
> previously accumulated instances of a given header.  So you can say
>
>     darcs send \
>         --discard-mail-header "From:" \
>         --mail-header "From: <[EMAIL PROTECTED]>"
>
> and get only one From header.  (Recall that header names are not
> case-sensitive, by the way.)

This looks useful as well.  The only change I would make is excluding
the : from the mail header.  The header name itself is From so I think
it makes more sense.

[snip]

> I'm not following.  I'm thinking of
>
>   sendEmailDoc ::
>     [(String, String)] -> String -> String -> Doc -> Doc -> Doc -> IO ()
>
> where the first value is an ordered list of (header, value) strings.

I'm sorry.  You're saying that we should just pass the headers to
sendEmailDoc instead of having make_email assemble them?  If so, I
don't have a problem with that.  But what stays in make_email? 
Perhaps everything should stay in make_email except "DarcsURL" and
"MIME-Version".  Please clarify if I'm still not on the same page as
you, though.

> > [1] http://www.jwz.org/doc/threading.html
>
> JWZ is always right.

And modest :P

--
Zachary P. Landau <[EMAIL PROTECTED]>

_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to