On 9 févr. 06, at 12:27, Tommy Pettersson wrote:
While I agree more code means more errors I find this sort of "silliness" rather cute.
Ok. I have no opinion either way on keeping/dumping the silliness. I just removed it out of embarrassment. Trying to be cute is a surefire way for me to fall flat on my face :-)
While to "fix" the test suite it is enough to remove the big time interval from it, I think the real problem is the exception is thrown at all on some dates. The user might accidently type such date. Is it possible to catch the exception and have darcs print something nicer, like "Either your repo or your computer is too old, troglodyte!"?
I'll look into adding a message like "Can't parse dates that far back!"... but before doing that, I'm going to poke the haskell date handling code a bit. I get the impression that this kind of overflow shouldn't be happening with time differences as small as 105 years. Something fishy is going on and I want to get to the bottom of it.
(*) The error message will still be useful, though, in case the user ever types stuff like "1000000000000 years ago".
-- Eric Kow http://www.loria.fr/~kow
PGP Key ID: 08AC04F9 Merci de corriger mon français. _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
