On Sun, Apr 23, 2006 at 08:03:54PM +0200, Juliusz Chroboczek wrote:
> 
> > hunk <file> <byte#> <line#> <#old bytes> <#old lines> <#new bytes> <#new 
> > lines>
> > old:
> > <the old data>
> > new:
> > <the new data>
> > end.
> 
> Notice the string ``end.'' at the end, checking for which will catch
> corruption in the new data.

Sounds good.

> Question: do we want to allow for arbitrary amounts of padding in
> order to page-align the data?  This might provide a slight performance
> benefit when mmapping.

That's already allowed by the lexing function dropping arbitrary
whitespace before "old" and "new". It would hurt us any time we needed
lots of small hunks from one file at once, though. I'm doubtful it will
be worth the added complexity of the patch writing code.


Thanks
Ian


_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to