On Sun, Apr 23, 2006 at 09:07:56PM +0200, Juliusz Chroboczek wrote: > I'm resending this old patch of Jason's as a reminder. ... > I am definitely in favour of this patch, but I would like to know: > > - how it impacts memory usage of pull (as opposed to record, where it > certainly helps); > - how it interacts with Jason's work on the new patch format. > > If anyone has any clues, I'm all ears.
It ought to also harm memory use on Pull, but that'll only be an issue if one runs pull -a. The new patch format ought to make this change matter less, how much so remains to be seen. I'm ambivalent on this patch. It'd definitely be nicer to figure out the memory usage/time behavior of our lazy patch reading code (which seems to not be as lazy as we'd like when reading a single very, very large hunk). But if noone is up for that, this workaround doesn't seem too bad. Although, it does optimize the case of a single massive file, while greatly hurting the case of a massive number of reasonably-sized files, which sort of seems like you're optimizing for the rare, insane case, while leaving the more common (but also somewhat insane) case with extremely poor memory behavior. -- David Roundy http://www.darcs.net _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
