> I haven't tested the patch, but the code looks clean and I look
> forward to a feature like this.
Same here.
Tony, could you please resubmit this patch without the code for
checking the pref? It's not needed, as Darcs will already accept a
line of the form
ALL check-patch=foo
or
record check-patch=foo
in prefs/defaults and do the right thing.
I'm also not sure that Record.lhs is the right place to put the code;
I suggest you move it to Test.lhs.
I'm also looking forward to seeing the same option implemented for
apply and pull. (Push is easy once you've done apply.)
> Does this preserve atomticity? That is, are all patches checked
> before darcs decides to accept the patches or is it patch by patch and
> can fail in the middle?
Well, as it's only implemented for record, there's only one patch to
check. But your point stands w.r.t. a future implementation in apply.
Juliusz
_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
