Hi Juliusz, On Mon, May 15, 2006 at 02:58:23 +0200, Juliusz Chroboczek wrote: > Eric, we've been through this discussion before, and I have asked that > people should not submit patches with non-TeX markup to source files. > > If you disagree with this decision, let us have the discussion again. > But until we do, please do not try to sneak in markup in Haskell > comments in this way.
I think there must have been a miscommunication on my part. To begin with, I promise I was *not* trying to sneak Haddock markup into the source. I was basically delivering what I thought was a correction to my previous comment. In fact, I had proposed just this change a long time ago, on 8 April and since nobody said anything back, I thought the change I proposed was ok: http://article.gmane.org/gmane.comp.version-control.darcs.devel/4273 My three mistakes here were: 1. Sitting on the patch for a long time (which means that the comment commes out of context) 2. Not making it super-explicit that I was proposing this as an alternative, less-intrusive, form of markup, and asking if you approved of this change. 3. Not refering in my darcs send summary the mail from 2006-04-08 where I said I would do this. Now let me motivate my patch a little better to show why I thought it would be less annoying to you, Juliusz. You had said in the thread parent: I prefer comments to be separated from the type, so that the type remains compact and easily readable. But that's just me. So that's exactly what I thought I did, separated the comment from the type. -- BEFORE -- apply :: WriteableDirectory m => [DarcsFlag] -> Bool -- ^ working directory - if True, this means some inconsitencies such -- as removing a non-empty directory are treated as warnings, not -- errors. When in doubt, set to False. -> Patch -> m () -- AFTER -- -- longish patch comment elided apply :: WriteableDirectory m => [DarcsFlag] -> Bool -- ^ working directory -> Patch -> m () See what I mean? Though I ended up adding more markup, the important thing, or so I thought, was the comment was now take out of the type. The point here is not that I think this version of things is better, but to illustrate that I was really acting in good faith. Anyway, to sum up: * I was only submitting something which I said I would submit a long time ago and to which nobody seemed to have objected * I was submitting something specifically upon a stated preference on Juliusz part that the comment stuff be separated from the type So please accept my apology for the poor communication, and preferably also, my defence of my good faith. Best, -- Eric Kow http://www.loria.fr/~kow PGP Key ID: 08AC04F9 Merci de corriger mon français.
pgpgz3WylGZbo.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
