On Fri, Aug 04, 2006 at 08:23:46PM +0200, [EMAIL PROTECTED] wrote: > Some test suite fixes for unstable.
Thanks! These look nice. > The test external.pl created many garbage baz dirs in the tests > dir, so I changed it a bit. > > The pull_two test hangs unless DARCS_EMAIL is set. I was > thinking about unsetting that environment variable in the test > harnesses to catch mistakes like this, but then again, one day > someone could find a bug with one of the test scripts _because_ > they have that variable set, so I don't know... Unsetting DARCS_EMAIL in the harness does sound like a good idea to me, as this is a very common mistake (by me, mostly). We can easily reset it in the tests themselves, to verify it works. In fact, that's another approach we could use sometimes rather than creating a default author or specifying the author on the command line. I think a more uniform test environment is a good thing, in general, at least with regards to issues like this. We already reset HOME so that ~/.defaults won't change the test behavior. -- David Roundy _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
