Issue 142 must have slipped by me when it was first posted. Can anyone think
of any reason why we would want the catch I removed to fix this bug? It seems
to me that if you asked to open a logfile and there was any sort of error,
you'd want to report it. But maybe someone else can think of a case where that
isn't true.
Note that the same problem exists in get_description of Send.lhs. I don't have
time to fix it tonight, but I'll try to get to it tomorrow. If anyone beats me
to the punch, that's fine with me.
Wed Aug 9 23:40:35 EDT 2006 Zachary P. Landau <[EMAIL PROTECTED]>
* Raise exception if unable to open logfile (issue142).
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
New patches:
[Raise exception if unable to open logfile (issue142).
Zachary P. Landau <[EMAIL PROTECTED]>**20060810034035] {
hunk ./Record.lhs 379
- - do ls <- (lines `liftM` readBinFile f) `catch` \_ -> return []
+ do ls <- (lines `liftM` readBinFile f)
}
Context:
[Minor tweaks to list_authors.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060720180602]
[add some changelog entries
Tommy Pettersson <[EMAIL PROTECTED]>**20060718152611]
[add some changelog entries
Tommy Pettersson <[EMAIL PROTECTED]>**20060616150558]
[Added elc and pyc to binaries.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060713184214]
[Run ssh/scp/sftp quietly.
Eric Kow <[EMAIL PROTECTED]>**20060707025245
This is useful for silencing Putty, and could also be for OpenSSH should
we decide to stop redirecting to /dev/null.
]
[Refactor calls to ssh/scp/sftp.
Eric Kow <[EMAIL PROTECTED]>**20060706202509
]
[Added up links in web interface.
Peter Stuifzand <[EMAIL PROTECTED]>**20060610082238
Added a link to the 'projects' part of the cgi repository interface, so that
you go back to the project list.
]
[Merge makefile targets test_perl and test_shell into test_scripts.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060607223134
This should keep parallel make from breaking.
]
[bump version to 1.0.8pre1
Tommy Pettersson <[EMAIL PROTECTED]>**20060522122655]
[Add a test suite for calling external programs.
Eric Kow <[EMAIL PROTECTED]>**20060521045407
For now this only includes a test for ssh (issue171).
]
[Add warning to Eric's SSHControlMaster rework.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060528194136]
[Only launch SSH control master on demand (fixes issue171)
Eric Kow <[EMAIL PROTECTED]>**20060528093000
A secondary benefit is that this encapsulates the use of the control
master functionality and consequently simplifies calling ssh. There is
no need to deal with the details of launching or exiting the control
master.
]
[Fail with a sensible message when there is no default repository to pull from.
[EMAIL PROTECTED]
[Extend test suite for patch matching.
Eric Kow <[EMAIL PROTECTED]>**20060513192501
]
[Implement help --match (issue91).
Eric Kow <[EMAIL PROTECTED]>**20060513185610
Also, refactor matching code in a way that encourages developers
to document for help --match any new matchers they create.
]
[Replace dateparser.sh with more general match.pl for testing --match.
Eric Kow <[EMAIL PROTECTED]>**20060513104942
]
[Add tests for pristine error and quiet mode when removing a directory.
Eric Kow <[EMAIL PROTECTED]>**20060513100021]
[Suppress non-empty dir warning if Quiet.
Eric Kow <[EMAIL PROTECTED]>**20060513053456]
[Replace test rmdir.sh with rmdir.pl.
Eric Kow <[EMAIL PROTECTED]>**20060513043823]
[TAG 1.0.7
Tommy Pettersson <[EMAIL PROTECTED]>**20060513171438]
[make 1.0.7 latest stable source on web page
Tommy Pettersson <[EMAIL PROTECTED]>**20060513000703]
[add some entries to the change log
Tommy Pettersson <[EMAIL PROTECTED]>**20060512235752]
[bump version to 1.0.7
Tommy Pettersson <[EMAIL PROTECTED]>**20060512235738]
[TAG 1.0.7rc1
Tommy Pettersson <[EMAIL PROTECTED]>**20060508101408]
[bump version to 1.0.7rc1
Tommy Pettersson <[EMAIL PROTECTED]>**20060508101349]
[fix error is is_pipe test in error reporting. (fixes Issue160)
David Roundy <[EMAIL PROTECTED]>**20060501142114
The trouble was that Ian (quite naturally) assumed that my C function
stdout_is_a_pipe returned nonzero for true, whereas for some very, very
backwards reason it returned zero for true, and its result was properly
interpreted. So I caused this bug by my (unexplained) backwards
programming, but it was introduced when Ian refactored the C code. :(
]
[TAG 1.0.7pre1
Tommy Pettersson <[EMAIL PROTECTED]>**20060427095905]
[Add forgotten file umask.h.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060423174844]
[Add --umask to all commands that write to the current repository.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060407195655]
[Add option --umask.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060407194552]
[Actually switch umasks in withRepoLock.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060407194202]
[Implement withUMask.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060407193312]
[Add umask.c.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060407193255]
[Propagate opts to withRepoLock.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060325190622]
[Provide some error reporting for remote identifyRepository.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060325234958]
[Note on sftp usage and other fixes.
Dave Love <[EMAIL PROTECTED]>**20060403122032]
[Tidy help command.
Eric Kow <[EMAIL PROTECTED]>**20060402225837]
[Display list of subcommands when getting help on a supercommand.
Eric Kow <[EMAIL PROTECTED]>**20060402190038]
[Allow for non-empty subdir when applying rmdir patch to working dir.
Eric Kow <[EMAIL PROTECTED]>**20060405231909
Do not delete the directory; just print a warning. Fix for issue154.
]
[Add a 'is working dir' flag to PatchApply.apply.
Eric Kow <[EMAIL PROTECTED]>**20060405225201
Half of the solution to issue154. This is so that we can have different
behaviours when applying to the working directory, as opposed to the
pristine tree.
]
[Add test case for issue154 (rmdir on non-empty subdir in working).
Eric Kow <[EMAIL PROTECTED]>**20060402134933]
[write with fancyPrinters to pager (issue108)
Tommy Pettersson <[EMAIL PROTECTED]>**20060319234103]
[make Printers choose policy for supplied file handle
Tommy Pettersson <[EMAIL PROTECTED]>**20060319233723]
[Add a flag to disable use of SSH control master.
Eric Kow <[EMAIL PROTECTED]>**20060320235217]
[More detailed comments for SSH control master.
Eric Kow <[EMAIL PROTECTED]>**20060320235200]
[Multiplex transactions over a single ssh connection (issue32).
Eric Kow <[EMAIL PROTECTED]>**20060317233337
Eliminates the need to type your password a million times. This
requires a recent version of OpenSSH with the ControlMaster feature, but
it is harmless if you do not have it.
]
[Refactor calls to ssh.
Eric Kow <[EMAIL PROTECTED]>**20060317214816
Also, separate out the argument for the remote address in some calls.
This makes it easier to implement functionality like use of the
ControlMaster feature.
]
[Refactor external-merge feature to use CommandLine.parseCmd.
Eric Kow <[EMAIL PROTECTED]>**20060320235932
]
[Add a --diff-command flag.
Eric Kow <[EMAIL PROTECTED]>**20060318001522]
[remove spurious '.' in doc
Eric Kow <[EMAIL PROTECTED]>**20060114230020]
[Added additional common binary image file formats to binary regex.
Daniel Freedman <[EMAIL PROTECTED]>**20060321002940]
[Added a RSS link to common.xslt.
Peter Stuifzand <[EMAIL PROTECTED]>**20060321222242
With the RSS link in the head tag it is easier for RSS reader to find the
link.
]
[Add --logfile and --delete-logfile options to send command.
Zachary P. Landau <[EMAIL PROTECTED]>**20060114214510]
[Fix merge conflicts.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060325182457]
[docfix, pull can take more than one URL
Tommy Pettersson <[EMAIL PROTECTED]>**20060319193913]
[Use withRepoLock systematically in Repository.lhs.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060303175729
Unlike the other functions in Repository.lhs, get_unrecorded and sync_repo
used to require that the caller chdir to the right place. This fixes this
inconsistency.
]
[Add -i as an alias for --interactive.
Zachary P. Landau <[EMAIL PROTECTED]>**20060302184640]
[Fix a button bar layout bug (wxDarcs).
Eric Kow <[EMAIL PROTECTED]>**20060307033857]
[Minor simplifications of DateMatcher.lhs.
Eric Kow <[EMAIL PROTECTED]>**20060317212529]
[refactor amInRepository, am_in_repository and findRepository
Eric Kow <[EMAIL PROTECTED]>**20060115111509
replace helper functions with general seekRepo function
also refactor am_not_in_repository
]
[remove redundant import.
David Roundy <[EMAIL PROTECTED]>**20060318122848]
[Minor tweaks to manual.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060307143305]
[Fix merge conflicts.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060307135524]
[Improved support for absolute paths (issue39)
Eric Kow <[EMAIL PROTECTED]>**20060304111532
This modifies fix_maybe_absolute so that if you specify a repository
directory, any absolute paths prefixed by this directory are converted
to be ones relative to the repodir.
The following commands now account for arguments which are absolute
paths but refer to files in the repository:
add, amend-record, annotate, changes, diff,
mv, record, remove, replace, revert, whatsnew
The following commands are not actually affected, though the code
is changed:
apply, push, pull, put.
This patch also slightly refactors FilePathUtils.lhs
]
[Enable tests for absolute paths.
Eric Kow <[EMAIL PROTECTED]>**20060304104355]
[--repodir for changes (RT #196 and #567)
Eric Kow <[EMAIL PROTECTED]>**20060109001224
Changes already accepts a --repo flag for possibly remote repo dirs, but there
is no reason not to also accept --repodir. The gain in consistency outweighs
the cost in redundancy.
Also, do not attempt to get_repodir unless --repo is in the arguments. This
is so that --repodir can work with relative paths. (Otherwise, darcs tries to
change directory twice, which is bad).
]
[--repodir argument for get (RT #196 - controversial?)
Eric Kow <[EMAIL PROTECTED]>**20051230133605
get already accepts a --repo-name flag, but I see no reason to keep this
distinction, especially if we accept that init should accept --repodir
In this implementation, we also keep the old --repo-name around for backwards
compatability (of dubious value here), but the internal representation is
changed to that of repodir
]
[--repodir argument for several commands (RT #196 and RT #559)
Eric Kow <[EMAIL PROTECTED]>**20051230021652
Commands affected: dist, optimize, repair, replace, setpref, tag, trackdown
Includes a small repodir test script.
Note that wrt RT #196
* replace and setpref (marked "no need" in the bug report -- but I don't see why not)
* changes (--repo) untouched [ I'd suggest having both flags available ]
* get (--repo-name) [ no reccomendations ]
]
[Added --repodir argument to init (RT #104 and part of RT #196)
Eric Kow <[EMAIL PROTECTED]>**20051230005424
This implementation also tries to create the repodir if it does not exist.
]
[make "-f" a synonym for "--force"
[EMAIL PROTECTED]
[Correct gui patch selection for commands like obliterate.
Eric Kow <[EMAIL PROTECTED]>**20060307032303
The gui patch selection system did not reverse/invert patches in
commands that need this behaviour (obliterate, unrecord). We solve
the problem by relying on code which factorises common behaviour
between the text and graphical patch selection systems.
]
[Refactor output end of SelectChanges.
Eric Kow <[EMAIL PROTECTED]>**20060307032052]
[Fix layout bug in OS X Tiger (wxDarcs).
Eric Kow <[EMAIL PROTECTED]>**20060302142517
Seems the solution to all gui ills is to add another panel.
]
[Resolve darcs gui conflict.
Eric Kow <[EMAIL PROTECTED]>**20060302010257
Pull.lhs was conflicting with Edwin Thomson's 2005-12-08 patch
"Don't make merge folders when we don't need them". This
patch merges the changes.
]
[Correct copyFrameworks script (gui, osx).
[EMAIL PROTECTED]
All binaries and libraries have some entry which tells what libraries
they are linked against. Any libraries which are not on the vanilla OS
X need to be copied into the application bundle so that it will work
anywhere. Whilst copying the libraries, you also need to change the
entries refering to these libraries so that they point to the
application bundle, and not their original path (e.g. /usr/local/lib).
I had done this for the binary, but not for the libraries being copied.
Also, make the copying of libraries recursive.
]
[Correct compilation of gui code in console mode.
Eric Kow <[EMAIL PROTECTED]>**20060131013107]
[Scripts and makefile target to distribute wxDarcs on OS X.
Eric Kow <[EMAIL PROTECTED]>**20060131012439
Creates an application bundle and a .dmg file.
]
[Add a standalone graphical interface.
Eric Kow <[EMAIL PROTECTED]>**20060131012036
The gui code prior to this patch allows graphical darcs forms to be run from
the command line. This builds off that functionality by adding a graphical
front-end, allowing users to access these forms with a click of a button.
In other words, this allows users to run darcs without the command line.
Much more work will have to be done on this front end before it is as usable as
the command-line darcs, but hopefully patch shall kick things off.
]
[Send darcs commands' output to log (gui only).
Eric Kow <[EMAIL PROTECTED]>**20060130232608
If running in SubGui mode, darcs commands send their output to wxWidgets log
instead of stdout, because under the standalone gui, this output would
otherwise be hidden.
]
[Add a lock mechanism for graphical interfaces.
Eric Kow <[EMAIL PROTECTED]>**20060130215323
Add a distinct lock for the GUI. What makes this lock different is
that taking and setting the lock are done seperately, instead of
using an atomic operation like withRepoLock. This allows us to
assign the releasing of the lock to GUI events like closing a window.
This would be useful for a standalone interface to prevent weird
race conditions, for example, from mulitple Record windows being open.
Note that withLock is not enough for this purpose; the lock would
already be released before the user even touches the window.
]
[Make unpull, unrecord, obliterate accept --gui.
Eric Kow <[EMAIL PROTECTED]>**20060130201041
This also has the side effect of them accepting --interactive.
]
[Abstract the patch-viewer widget.
Eric Kow <[EMAIL PROTECTED]>**20060130153753
We shouldn't care how the patch-viewer is implemented.
]
[Add a SubGui flag.
Eric Kow <[EMAIL PROTECTED]>**20060130153530
The SubGui flag enables commands to be run under a main GUI.
The idea is that wxhaskell's start function really does not
like to be called more than once, so we avoid calling it
a second time if a main gui already has done so.
]
[Remove tabs in graphical output.
Eric Kow <[EMAIL PROTECTED]>**20060130134403
Wxhaskell has trouble when tabs are included in the text to be
displayed. We quietly convert these tabs into spaces.
]
[(GUI) Create GuiUtils.lhs, move tree widget code to it.
Eric Kow <[EMAIL PROTECTED]>**20060129004445
Also, simplify the tree widget code. This file will provide a
central place for various graphical odds and ends.
]
[Refactor calls to Rez in makefile (OS X).
Eric Kow <[EMAIL PROTECTED]>**20060125235731]
[Fix layout bugs in GUI (buttons were being hidden).
Eric Kow <[EMAIL PROTECTED]>**20060122215729
For some reason, scrolled windows seem to need to be inside of panels
for them to behave correctly when their parent windows are resized.
Otherwise they hide the button bars used in Record and SelectChanges.
Also, slightly simplify GUI code to avoid proliferation of widgets.
]
[Fix conflict between Zachary P. Landau's and my patch.
Eric Kow <[EMAIL PROTECTED]>**20060306010743
]
[Refactor SelectChanges.lhs.
Eric Kow <[EMAIL PROTECTED]>**20060306004421
1. Rearrange parameters of with_any_selected_changes to favour eta reduction.
2. Refactor type definitions for with_selected...changes functions to
indicate that it's all the same thing.
3. Separate patch counting with decisions about which patches we should
consider.
]
[Perl tests: get rid of 'darcs: <stdin>: hGetLine: end of file' messages
Marnix Klooster <[EMAIL PROTECTED]>**20060304180420
These were printed because 'n' was not answered to 'Really unpull' and 'Really
obliterate' questions.
Also, do not send superfluous '\n' to darcs in echo_to_darcs().
]
[Test pull.pl, CREATE_DIR_ERROR: removed TODO now that directory name is printed in error message
Marnix Klooster <[EMAIL PROTECTED]>**20060304164033
Also removes a superfluous (and erroneous) chdir statement, which tried to
change to non-existing directory templ (last character was ell instead of one).
Also improves the description of this test.
]
[Make darcs exit after last patch in changes --interactive.
Zachary P. Landau <[EMAIL PROTECTED]>**20060303014534
Currently, hitting 'j' on the last patch in changes --interactive has
no effect. This patch will cause darcs to exit, making the command
more consistent with an interactive pull.
]
[Fix crash when using changes --interactive with --patch or --match
Zachary P. Landau <[EMAIL PROTECTED]>**20060303013820]
[Chdir systematically in Repository.lhs.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20060303181824
Unlike the other functions in Repository.lhs, applyToPristine, get_unrecorded
and sync_repo used to require that the caller chdir to the right place.
This fixes that inconsistency.
]
[Extend argument substitution for --external-merge
Daan Leijen <[EMAIL PROTECTED]>**20060214062042
Argument substitution used to work on words at the time which made
it difficult to use Windows merge tools like the supernice tortoiseMerge.
Now, substitution of "%a" etc. takes place everywhere and we can write:
--external-merge 'tortoiseMerge /base:"%a" /mine:"%1" /theirs:"%2" /merged:"%o"
To make it complete, we substitute "%%" to "%".
]
[boring += autom4te.cache/
Kirill Smelkov <[EMAIL PROTECTED]>**20060130071416]
[omit the "Finished getting." message when --quiet
Simon Marlow <[EMAIL PROTECTED]>**20060120074731]
[Enable GUI on MacOS X with /Developer/Tools/Rez.
Eric Kow <[EMAIL PROTECTED]>**20060121004325
Without this command, the darcs GUI does not take focus under MacOS X.
]
[Reimplement flexible GUI widget for whatsnew.
Eric Kow <[EMAIL PROTECTED]>**20060121001049
The current implementation was not working, maybe as a result of
a wxhaskell or WxWidgets bug in which resized widgets lose their
new sizes when the parent window is resized.
The new implementation works around this by displaying patches in
tree form. Each node is a patch summary, and expanding that node
reveals the full patch.
]
[Freshen GUI code so that it compiles.
Eric Kow <[EMAIL PROTECTED]>**20060121000818]
[Don't make merge folders when we don't need them
[EMAIL PROTECTED]
]
[Add "y" and "n" commands to changes --interactive.
Zachary P. Landau <[EMAIL PROTECTED]>**20060115054548]
[Added test selection mechanism to makefile
Eric Kow <[EMAIL PROTECTED]>**20051230230008
If the developer creates a file test/tests_to_run with the filenames
of the tests to run, only those tests will be run.
]
[Save email description file if a send fails
Zachary P. Landau <[EMAIL PROTECTED]>**20060114204826]
[posthook success/failure messages with --verbose only
Jason Dagit <[EMAIL PROTECTED]>**20060113204930
Changes behavior of posthook status messages. Use --verbose to have
posthook status messages. Error reporting can be turned off with
--quiet. Note: The command run by the posthook might still generate
output, this patch does not address this output.
]
[bump version to 1.0.7pre1
Tommy Pettersson <[EMAIL PROTECTED]>**20060301000323]
[show 1.0.6 as latest stable source on web page
Tommy Pettersson <[EMAIL PROTECTED]>**20060301000158
Forgot this, again :-/
]
[removed last bits of create-repo from makefile (issue14)
Jason Dagit <[EMAIL PROTECTED]>**20060113212432]
[call unnamed patches "changes" in interactive patch selection dialogue
Tommy Pettersson <[EMAIL PROTECTED]>**20060113203829
It currently affects record, revert and amend, but will generally do
"the right thing".
]
[Improved single-character prompt (RT #261)
Eric Kow <[EMAIL PROTECTED]>**20060108225741
In the dialogue prompting for a single character as a response, if the
user just presses enter, we behave is if we got an invalid response.
This way, the user gets a little bit of feedback that he should respond
differently.
Also: refactors the case where there is a default answer and where the
user may press '?' for help.
]
[use _darcs/pristine in regression tests
Eric Kow <[EMAIL PROTECTED]>**20060108222000]
[Use _darcs/pristine instead of _darcs/current.
Juliusz Chroboczek <[EMAIL PROTECTED]>**20051215180814
All versions of Darcs since 1.0.2rc1 are able to handle either name. This
will break compatibility of new repositories with older versions.
]
[TAG 1.0.6
Tommy Pettersson <[EMAIL PROTECTED]>**20060228111841]
Patch bundle hash:
bb267cd639f3b7bd2bf29ed745bc4f081e13deff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFE2q6tMi+gvMn4IFIRAjxQAKDY5/kDXQRT6rs7DYJ1Q4fYE5bgSQCffUx0
8qPMOGRcQ6OvOyHxaHC3qfU=
=Zsrd
-----END PGP SIGNATURE-----
_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
