On Sun, Sep 10, 2006 at 06:06:49AM +0200, Eric Y. Kow wrote: > On Sat, Sep 09, 2006 at 22:10:14 +0200, Tommy Pettersson wrote: > > I have changed the > > Windows code too, but have not tried to compile it since I don't > > have Windows. > > I have a trick for that. I just set #define WIN32 (after recording > the patch so I can easily revert it)
Duh! Of corse. I was thinking in a too big picture; all I need is to check the file with the compiler, not necessarily creating a working executable. Well, it turns out it *doesn't* compile with WIN32 for very obvious reasons, like misnamed identifiers. I'll send in an amended version later today. [Probably much later today. As I'm writing this my parents called. They are coming here! In two hours!! Both me and my apartment looks like a total mess... got to go!] > 1) Eric - find Juliusz's message re: stderr redirection > (I assume it's not the message where he accepted my patch) > I would be happy for stderr to NOT be redirected by > default, but just want to double-check the arguments, > just to be conservative and avoid changing behaviour > unless necessary. I was thinking of the following (quoted from Juliusz mail): | Note that, unless I'm missing something this will also change the | behaviour of other commands: ``darcs diff'', for example, will now | push any warnings from diff through the darcs printer, rather than | printing them directly. And ``darcs dist'' will print any warnings | from tar on stdout rather than stderr, which is clearly wrong. I | haven't checked the other uses of exec and friends, but I bet there | are other such issues. I think Juliusz is both missing something and is right. (Or I am missing something: "redirect stderr to stdout" can mean two different things, this can get very confusing.) Anyway, even before exec_(fancy), exec would always redirect stderr to the same place as stdout, and in some cases this is surely not what we want. So the change is good. It should just be consistent between Unix / Windows. -- Tommy Pettersson <[EMAIL PROTECTED]> _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
