Hi Tommy, On Mon, Sep 11, 2006 at 12:39:29 +0200, [EMAIL PROTECTED] wrote: > Mon Sep 11 12:29:33 CEST 2006 Tommy Pettersson <[EMAIL PROTECTED]> > * rewrite Exec.lhs, new exec interface with Redirects > Make the code structure a bit simpler and easier to understand. > Only one (fancy) version of exec.
I took a look at this ; it seems correct and a definite improvement. Minor note: tipple? Is this a tipple a three-tuple (new vocab for eric), or is it a typo? > Mon Sep 11 12:32:16 CEST 2006 Tommy Pettersson <[EMAIL PROTECTED]> > * update all usages of exec (and exec_fancy) to new interface I have some hesitations here: copySSH and execSSH have switched from Nothing Nothing (Just "/dev/null") to Null Null Null Are these changes deliberate? If not, I believe these should be AsIs AsIs Null The reason (I think) is that putty ssh (i think) really does not like having stdin and stdout redirected from/to /dev/null, because it does its password prompts there. OpenSSH appears to be more clever, and not care; it just talks with the actual terminal. That being said, if some Windows users test this out and report that it works fine with them (using putty to do darcs pull, push, get over ssh) then I will happily accept the patch as is. Cheers, -- Eric Kow http://www.loria.fr/~kow PGP Key ID: 08AC04F9 Merci de corriger mon français.
pgpB6q2aCQrLH.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
