Hi Hoan, Some more requests:
Mostly from the community discussion, particularly, Juliusz's comments.
It looks like there is more room for this discussion to continue, so
please note that the review process might take quite a while!
In the meantime, please...
1. Improve the user interface. Two general ideas are
to avoid getting this mechanism confused with the ignored
patch one, and just to make things clearer in general.
- the default ignore file should not be 'ignore' but
something like 'ignored_files'
- the pref for where the ignored_files is should also be
changed - how exactly, i'm not sure. 'ignoredfilesfile'
sounds silly
- using --ignore to mean "don't ignore the ignored files"
is counterintuitive. Maybe something like '--ignored-files'
is better.
2. Improve the documentation. You should definitely clarify the
relationship between boring and ignore.
3. Minimise your patches - this is just a minor nitpick. Something I
noticed about the RepoPrefs code. Purely stylistic changes that have
nothing to do with the issue at hand (inserting needed spaces,
rearranging code) should generally be made in a separate patch. They
are welcome, but shouldn't be made riders to other patches.
Some general notes:
A. It is becoming quite clear that we will not be taking the
ignore/unignore commands (though the feature is still up
for consideration)
B. One thing which makes me a bit skittish about this patch is that
get_unrecorded is used in many parts of darcs. For example, I
believe that pull uses it because we need to merge the pulled
changes with the pending ones.
Are you sure there aren't any unpleasant surprises down the corner?
Could you please explain to me how it works, for example, when I pull
a patch which affects an ignored file to which I have made changes
(sort of the whole point)?
C. Please use darcs send to submit your patches. If this is not
possible, please do darcs send -o to generate a file, and attach
that. It's just me being lazy :-) I like getting the patch
summaries in the mail instead of having to dig through them in
the bundle.
Thanks much!
--
Eric Kow http://www.loria.fr/~kow
PGP Key ID: 08AC04F9 Merci de corriger mon français.
pgppKMlF2no75.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
