Hi David, On Thu, Sep 28, 2006 at 10:56:34 -0700, David Roundy wrote: > Sun Sep 17 14:41:36 PDT 2006 David Roundy <[EMAIL PROTECTED]> > * clean up unrevert and pending handling.
There's a slight problem with this patch. Having DarcsUtils import Exec
creates a circular dependency when combined with Tommy's exec stuff (he
uses impossible.h, which uses bug from DarcsUtils).
What do you recommend? Moving bug to something "lower"? Moving the
edit_file and view_file actions to another module? In any case, I'm
taking Tommy's patch and waiting for your response.
Otherwise, minor complaint: I would have found the patch easier to
understand if you have split the pending refactor from the other
cleanups (e.g. the edit_file and view_file stuff). Not asking you to
amend the patch or anything :-), just being picky (*)
Otherwise, I don't understand what all you're doing with the pending,
but it looks like refactoring to me, and I trust you know what you're
doing.
Best,
--eric
(*) I've been doing that a lot. Sorry to all patch submitters.
Will settle down and focus on the important stuff.
--
Eric Kow http://www.loria.fr/~kow
PGP Key ID: 08AC04F9 Merci de corriger mon français.
pgpF3Vpo8NRyQ.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
