On Wed, Dec 20, 2006 at 09:21:49AM +0000, Benedikt Schmidt wrote:
> This patch fixes a bug reported on #darcs:
> $ darcs replace --token-chars '[^ \n\t]' x y transmute
> darcs failed:  Space not allowed in tokens:  [^ \n\t]
> 
> An earlier bugfix added this restriction to token-chars, but i don't
> think it should apply to delimiting characters.

I seem to recall that the restriction was because of bugginess in older
darcs' parsing of replace patches, which hasn't changed and applies equally
to either token or delimiter characters.  Tommy can correct me here if I'm
wrong (or explain further if I'm right), as he's worked on this.

And I think spaces *should* be equally allowed as token or delimter
characters.  The question is whether it's worth a repository format
transition.  I think it probably is, but perhaps not now (unless someone
wanted to step up for this...).
-- 
David Roundy
http://www.darcs.net

_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to