On Wed, Jan 31, 2007 at 04:48:26PM +0000, Benedikt Schmidt wrote: > This patch is meant as a proposal for the breakCommand problems and handles > David's DARCS_EDITOR=emacs --eval "(setq make-backup-files nil)" by using > > setEnv "DARCS_ARGUMENT" arg > system 'cmd "$DARCS_ARGUMENT"' > > It only changes exec_interactive which is used by edit_file and view_file on > Unix > and doesn't touch darcs or ssh invocations or changes anything on windows.
Looks reasonable to me. My only question would echo Tommy's, I'd wonder if there isn't a varient of system that will allow us to set the environment. But I think you've already answered that. > Some things that we have to decide on: > Do we want this behaviour on windows too? I think we would, but wouldn't mind letting windows lag, if there isn't anyone around who's motivated and competent to bring it up to snuff. > What about DARCS_SSH and the other commands using exec? I don't know. These are more critical than exec_interactive, so I'd hesitate to change them, and suspect that only on windows would users particularly be likely to specify something that would break under the current behavior. In short, I'm torn. Does anyone else have an opinion? Particularly Eric might have an opinion, as he's borne the brunt of quite a few ssh-related bug reports... -- David Roundy Department of Physics Oregon State University _______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
