Il giorno 03/mar/07, alle ore 10:30, Eric Y. Kow ha scritto:
Thanks Dario and David, Dario, sorry but I don't think I will be taking this patch. I'll confess that I haven't looked very deeply into the code, and am basing this more on your description than anything else. Dario said:This makes revert work on any file in the directory reverting them all and deleting the files not present in the darcs manifest.You might be able to accomplish the same thing by doing a rm -rf * and then a darcs revert (i.e. you revert the removal of the files, thus adding back the good ones). Counterintuitive as this might be, is it equivalent to the functionality of your patch?
Yes, the removal of any file and reverting everything has the same effect.
Likewise, David's suggestions are worth considering if you think the functionality is truly useful and you would like to resubmit. Note that whenever a new feature gets introduced, I try to be poll devel and maybe users for 'objections in principle', i.e. without looking at the code, if anybody would actually object to the new functionality being added to darcs. You can probably expect me to do the same for the new revert --look-for-adds should you choose to submit one.
I understand.
Also, your patch depends on a 'Initial import' patch, which I do not have; were you submitting against the official repository, or did you import the code from a source tarball? You can get the official unstable repo with darcs get --partial http://abridgegame.org/repos/darcs-unstable
I have done it from a source tarball, thanks for the link.
David said:I don't really care for the flag name, and am not sure I really likesticking this functionality into revert. A revert --look-for-adds would be almost like revert --hard, although wouldn't revert boring files. Revert --look-for-adds would have the advantage of doing what you want, if you usually record with the --look-for-adds flag. If we wanted to remove allfiles not in the manifest, perhaps adding both a --boring flag and a--look-for-adds flag would do the trick, so that revert --hard would beequivalent to revert --look-for-adds --boring.-- Eric Kow http://www.loria.fr/~kow PGP Key ID: 08AC04F9 Merci de corriger mon français.
Dario Meloni
PGP.sig
Description: Questa è un messaggio firmato elettronicamente
_______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
