On Sat, Mar 31, 2007 at 11:04:28AM +0200, Eric Y. Kow wrote: > > Wed Mar 28 18:08:28 PDT 2007 David Roundy <[EMAIL PROTECTED]> > > * make --set-scripts-executable work with get and hashed inventories. > > Ehh... I know I'm being a bit of a broken record here, but wouldn't it > be better to refactor this somehow? > > We already have this in Darcs.Patch.Apply and in the regular unhashed > inventories's get.
Indeed, it'd be better to unify the regular unhashed inventory's get with this new code, but I've been trying to avoid refactoring the regular code so as to reduce the risk of introducing bugs, particularly as I've been writing code pretty quickly (and thus, perhaps, sloppily). Ideally, I'd like to consider at some point scrapping the regular unhashed inventory's get, as the new code should itself be generic, or at least, that's the intent. But the new code may very likely will perform worse than the old (particularly in regard to memory), so I don't want to swap out the old until the new has gotten some pretty serious testing. Of course, you're thinking of a lower-level refactoring, to avoid the multiple copies of code that checks for "#!", which would make sense to do sooner... -- David Roundy http://www.darcs.net
signature.asc
Description: Digital signature
_______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
